Add new move_rotator.py SAL Script
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
reviewed
Oct 16, 2023
python/lsst/ts/standardscripts/maintel/mtrotator/move_rotator.py
Outdated
Show resolved
Hide resolved
tribeiro
approved these changes
Oct 18, 2023
|
|
||
| """ | ||
|
|
||
| def __init__(self, index: int, add_remotes: bool = True) -> None: |
There was a problem hiding this comment.
I think you can remove the add_remotes parameter now.
| await self.mtcs.move_rotator( | ||
| angle=self.target_angle, wait_for_complete=self.wait_for_complete | ||
| ) | ||
| if self.wait_for_complete: |
There was a problem hiding this comment.
Not sure I understand why you included this checkpoints here. Is the idea to provide a way for people to pause the script? I suggest you change it to be a single message, regardless of the value of self.wait_for_complete. Maybe something like:
await self.checkpoint(f"Move rotator finished.")
Or, if you want to provide information about the wait_for_complete, something like this:
await self.checkpoint(f"Move rotator finished; wait for complete: {self.wait_for_complete}.")
b1quint
added a commit
that referenced
this pull request
Oct 19, 2023
* Remove ``add_remotes`` argument from ``MoveRotator.__init__`` * Squeeze the checkpoints at the end to be a single line
b1quint
force-pushed
the
tickets/DM-41081
branch
from
f50ea8c
to
cf64040
Compare
b1quint
added a commit
that referenced
this pull request
Oct 20, 2023
* Remove ``add_remotes`` argument from ``MoveRotator.__init__`` * Squeeze the checkpoints at the end to be a single line
b1quint
force-pushed
the
tickets/DM-41081
branch
2 times, most recently
from
85a1d00
to
f850799
Compare
b1quint
force-pushed
the
tickets/DM-41081
branch
from
f850799
to
79ae437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new
move_rotator.pySAL Script. This depends on lsst-ts/ts_observatory_control#107.